Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graph network (partial) paused field added #56

Merged
merged 13 commits into from
Aug 10, 2023
Merged

feat: graph network (partial) paused field added #56

merged 13 commits into from
Aug 10, 2023

Conversation

sahra-karakoc
Copy link
Member

Issue link

#50

juanmardefago
juanmardefago reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@juanmardefago juanmardefago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we need to rebase (given that the commits for the allocation entity that it was based upon have changed when rebased and merged to main most likely)

juanmardefago
juanmardefago reviewed Aug 10, 2023
View reviewed changes
Copy link
Contributor

@juanmardefago juanmardefago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rebase issue, everything else looks good, although I'm not sure why after rebasing we still have allocation changes commits included in the PR 🤔

buf.gen.yaml Outdated Show resolved Hide resolved
@juanmardefago
Copy link
Contributor

Oh nevermind, we have those commits since you squashed merged into main, all good then

juanmardefago
juanmardefago approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@juanmardefago juanmardefago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small rebase issue, everything else looks good

@sahra-karakoc sahra-karakoc merged commit 8c3aacf into main Aug 10, 2023
2 checks passed
@sahra-karakoc sahra-karakoc deleted the sahra/graph-networks branch August 10, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanmardefago juanmardefago juanmardefago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahra-karakoc @juanmardefago